Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NFTs to existing Vault #95

Open
MarioProjects opened this issue May 21, 2022 · 4 comments
Open

Adding NFTs to existing Vault #95

MarioProjects opened this issue May 21, 2022 · 4 comments

Comments

@MarioProjects
Copy link

When I want to add NFTs I have to unstake first, add to the vault and then stake again. That causes paying fees for unstaking and re-stakign again and I don't know if variable staking rewards based on staked time too... Could be changed?

@ghost
Copy link

ghost commented Jun 21, 2022

I am on the same boat.

@numisman
Copy link

You can do the flash stake, but you will still have to pay the fees to do it. But at least you won't have to unstake and restake!

@ghost
Copy link

ghost commented Jun 22, 2022

@numisman flash stake works well when I want to stake one nft, instead of multiple steps.
But when I want to unstake one, I have to unstake->end cooldown->remove from vault->stake.
Is there a call to do all?
BTW, i set cooldown to 0 second, but when i do unstake, it always go to pendingCooldown status. the cooldown setting is not respected.

I really appreciate your help.

@numisman
Copy link

I understand there are ways to package these instructions into one transaction but I have not implemented it. In our case, we just go ahead and ask for two approvals and do the instructions to end cooldown ourselves after unstaking. It's a pain, but it works for now. This is definitely something I want to revisit once I have time. In the meantime, review some of the other issues that are in this repo - I believe others are attempting this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants