This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
fix dirDialog: incorrect result if path too short #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the selected directory / path on Windows is too short (shorter than the displayName?), then the function dirDialog() returned an incorrect path. Example: if the user selected "C:\" (root dir of disk), then the returned path is "C:\l Disk (C:)". The same goes for USB devices.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to issue #20 .
Platform: Windows 10
Summary: if a user selects the root of a disk / USB device (file picker), then the returned file path is incorrect. Example: user selects the root of disk C
C:\but the return value isC:\l Disk (C:). This bug seems to be related to the length of the file path which the user had selected. If the user selects a child directory (not the root of a disk/device), then the correct file path is returned. I tested this change on Windows 10 64 Bit.For an explanation please read the comment by @ncruces: #20 (comment)