Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag PvP #82

Closed
SaeedSoheili opened this issue Sep 6, 2018 · 5 comments
Closed

Flag PvP #82

SaeedSoheili opened this issue Sep 6, 2018 · 5 comments
Labels
bug Something isn't working In progress Extra attention is needed Ready for testing
Projects
Plugin Release

Comments

@SaeedSoheili
Copy link

SaeedSoheili commented Sep 6, 2018 •
edited
Loading

Hello
When is set pvp flag true and attack the player they are dont have damage and error in console:

2018-09-06 [11:53:41] [Server thread/CRITICAL]: Could not pass event 'pocketmine\event\entity\EntityDamageByEntityEvent' to 'Festival v1.0.7.5-dev': Undefined index: MinusMarigold98 on genboy\Festival\Main
2018-09-06 [11:53:41] [Server thread/CRITICAL]: ErrorException: "Undefined index: MinusMarigold98" (EXCEPTION) in "Festival-master/src/genboy/Festival/Main" at line 1112
2018-09-06 [11:53:41] [Server thread/DEBUG]: #0 Festival-master/src/genboy/Festival/Main(1112): pocketmine\utils\Utils::errorExceptionHandler(integer 8, string Undefined index: MinusMarigold98, string C:\Users\Administrator\Desktop\1.4\BoniGroup -Prison-1.4\plugins\Festival-master\src\genboy\Festival\Main.php, integer 1112, array Array())
2018-09-06 [11:53:41] [Server thread/DEBUG]: #1 src/pocketmine/plugin/MethodEventExecutor(38): genboy\Festival\Main->canPVP(pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #2 src/pocketmine/plugin/RegisteredListener(98): pocketmine\plugin\MethodEventExecutor->execute(genboy\Festival\Main object, pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #3 src/pocketmine/plugin/PluginManager(749): pocketmine\plugin\RegisteredListener->callEvent(pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #4 src/pocketmine/entity/Entity(892): pocketmine\plugin\PluginManager->callEvent(pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #5 src/pocketmine/entity/Living(532): pocketmine\entity\Entity->attack(pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #6 src/pocketmine/Player(3704): pocketmine\entity\Living->attack(pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #7 src/pocketmine/Player(2510): pocketmine\Player->attack(pocketmine\event\entity\EntityDamageByEntityEvent object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(132): pocketmine\Player->handleInventoryTransaction(pocketmine\network\mcpe\protocol\InventoryTransactionPacket object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/protocol/InventoryTransactionPacket(155): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleInventoryTransaction(pocketmine\network\mcpe\protocol\InventoryTransactionPacket object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\InventoryTransactionPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\InventoryTransactionPacket object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #13 src/pocketmine/Player(3033): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(162): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #15 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 2.191.232.32 18647, raklib\protocol\EncapsulatedPacket object, integer 0)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #16 src/pocketmine/network/mcpe/RakLibInterface(103): raklib\server\ServerHandler->handlePacket()
2018-09-06 [11:53:41] [Server thread/DEBUG]: #17 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
2018-09-06 [11:53:41] [Server thread/DEBUG]: #18 src/pocketmine/network/mcpe/RakLibInterface(80): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #19 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe{closure}()
2018-09-06 [11:53:41] [Server thread/DEBUG]: #20 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
2018-09-06 [11:53:41] [Server thread/DEBUG]: #21 src/pocketmine/Server(2263): pocketmine\snooze\SleeperHandler->sleepUntil(double 1536227621.4726)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #22 src/pocketmine/Server(2138): pocketmine\Server->tickProcessor()
2018-09-06 [11:53:41] [Server thread/DEBUG]: #23 src/pocketmine/Server(1715): pocketmine\Server->start()
2018-09-06 [11:53:41] [Server thread/DEBUG]: #24 src/pocketmine/PocketMine(237): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string C:\Users\Administrator\Desktop\1.4\BoniGroup -Prison-1.4, string C:\Users\Administrator\Desktop\1.4\BoniGroup -Prison-1.4\plugins)
2018-09-06 [11:53:41] [Server thread/DEBUG]: #25 C:/Users/Administrator/Desktop/1.4/BoniGroup -Prison-1.4/PocketMine-MP.phar(1): require(string phar://C:/Users/Administrator/Desktop/1.4/BoniGroup -Prison-1.4/PocketMine-MP.phar/src/pocketmine/PocketMine.php)

what I can do?
@genboy genboy added the bug Something isn't working label Sep 6, 2018
@genboy
Copy link
Owner

genboy commented Sep 6, 2018 •
edited
Loading

@saedsohili Thank you for the info, i will check and fix this soon.

If pvp flag is on both players are protected against pvp damage, now the bug is something with the 2 sided event EntityDamageByEntityEvent function in Festival plugin.

@genboy genboy added this to To do in Plugin Release Sep 6, 2018
@SaeedSoheili
Copy link
Author

Tnx
When it's fix? I need it a lot please do it faster

@SuperAdam47
Copy link

I have same error

@genboy genboy added the In progress Extra attention is needed label Sep 7, 2018
@genboy
Copy link
Owner

genboy commented Sep 7, 2018

@saedsohili @SuperAdam47
Testing fix at master https://github.com/genboy/Festival

@genboy genboy moved this from To do to In progress in Plugin Release Sep 7, 2018
@genboy genboy moved this from In progress to Done in Plugin Release Sep 8, 2018
@genboy
Copy link
Owner

genboy commented Sep 13, 2018

Let me know if something comes up
v1.0.7.6-dev ready at poggit

@genboy genboy closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working In progress Extra attention is needed Ready for testing
Projects
Plugin Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SuperAdam47 @SaeedSoheili @genboy