Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on decoding xz file with sha256 checksum #32

Closed
Shnatsel opened this issue Apr 15, 2020 · 0 comments · Fixed by #40
Closed

Panic on decoding xz file with sha256 checksum #32

Shnatsel opened this issue Apr 15, 2020 · 0 comments · Fixed by #40
Labels
bug

Comments

@Shnatsel
Copy link
Contributor

lzma-rs/src/decode/xz.rs

Line 364 in 3fcf0bb

CheckMethod::SHA256 => unimplemented!(),

This panic is trivial to trigger and may be used to mount a denial-of-service attack on a remote service that decodes XZ files.

Returning an error instead of panicking would be an improvement. https://crates.io/crates/sha2 can be used to implement the check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

decode/xz: do not panic on unsupported checksum lucab/lzma-rs
2 participants
@Shnatsel @gendx