Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature that warns the user of outliers before mapping is missing from GN2 #55

Closed
zsloan opened this issue May 21, 2015 · 2 comments
Closed

Comments

@zsloan
Copy link
Contributor

zsloan commented May 21, 2015

GN1 has a feature that pops up something warning the user if any outliers exist in the trait's sample/strain data and I believe it will automatically remove them as well. At the very least, we need to add back in the warning.

While this feature exists in GN1, the pop-up looks a little strange (aesthetically) so it might be a better idea to not borrow all the code.

@pjotrp
Copy link
Member

pjotrp commented May 21, 2015

I don't think we should use popups. I prefer the red warning textbox on top of the page or next to the search box. So people can search/run again without closing windows.

@zsloan
Copy link
Contributor Author

zsloan commented Mar 7, 2019

This feature was added; warning text appears below the submit button if there's an outlier.

@zsloan zsloan closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants