Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompts / data #38

Closed
jonschlinkert opened this issue Sep 12, 2016 · 3 comments
Closed

prompts / data #38

jonschlinkert opened this issue Sep 12, 2016 · 3 comments

Comments

@jonschlinkert
Copy link
Member

I recently introduced a bug that caused the license statement intended for a readme to be used as the license in package.json.

The bad news: I just pushed up a temporary fix for that bug, but it's not unlikely that other bugs will crop up as a result.

The good news: Data handling in generate is highly modular and the code for it is organized in a way that makes it easy to completely change. I'm working on that now. If anyone experiences regressions, please list them here. Sincerest apologies for any inconvenience

@dawsbot
Copy link
Contributor

dawsbot commented Sep 12, 2016

Link to fix? It'd be cool to learn and help prevent this type of bug in the future.

@jamen
Copy link

jamen commented Sep 12, 2016

I've experienced this bug recently too, just for the record. (same one involving license)

Was able to fix for myself just by regenerating.

@jonschlinkert
Copy link
Member Author

jonschlinkert commented Sep 12, 2016

I've experienced this bug recently too, just for the record. (same one involving license)

Good to know. I attempted a fix yesterday, you'll probably need to reinstall global generators and generate

Link to fix? It'd be cool to learn and help prevent this type of bug in the future.

I started working on a fix for this one a week or so ago. Let me try to get that wrapped up, then we can do a post-mortem. We should probably also open an issue here to discuss strategies for improving how data is handled by generate. sound ok?

edit: oh and of course @doowb or I would be happy to point you to anything in the code anytime. If anyone has question like "Where is X handled in generate?" please don't hesitate to ask. We should do a diagram that shows the architecture and how plugins are used (anyone good at doing diagrams?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants