Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: the reverse of inverse flags should be set on options #41

Closed
jonschlinkert opened this issue Sep 18, 2016 · 4 comments
Closed

bug: the reverse of inverse flags should be set on options #41

jonschlinkert opened this issue Sep 18, 2016 · 4 comments
Labels

Comments

@jonschlinkert
Copy link
Member

When --nofoo is set, it adds nofoo: true to the options. foo: false should also be added to the options. I thought yargs-parser did this but I might need to set an option for it. I think the best solution is to ensure this is done regardless of the args parser used.

@tunnckoCore
Copy link

it's seems you're wrong. one thing is --nofoo totally another is --no-foo i believe? and yargs/minimist does it? hm

@jonschlinkert
Copy link
Member Author

jonschlinkert commented Sep 19, 2016

it's seems you're wrong

I'm often wrong about a lot of things. This isn't one of them.

I guess I should ask what I'm wrong about... The code works for what I wanted. Are you suggesting we also support --no-foo?

@tunnckoCore
Copy link

tunnckoCore commented Sep 20, 2016

Are you suggesting we also support --no-foo?

If it's not supported currently, it make sense to be supported, yea. And it's more real and natural for me (and other would expect it, i believe) than --nofoo. :)

@jonschlinkert
Copy link
Member Author

ok, that makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants