-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance slowdown since p5js v0.5.14 #161
Comments
@generative-design/authors Can everyone please check this ... and tell us the behaviour on their machines? Please use the branch |
I've added v0.5.12, v0.5.14 and 0.5.16 to the libraries folder to make it easier for you to test. |
And added a test folder. |
On my machine... macbook pro v10.12 on chrome 63.0.3239.132 (Official Build) (64-bit):
on firefox 57.0.4 (64-bit):
|
Same here. Tested with chrome 64.0.3282.85 (64-bit) and firefox 57.0.4 (64-bit) on macbook pro with os x 10.12. |
Thanks for looking into it @bohnacker ! How do you think we should proceed? |
@joeyklee Can you ask via your insider link the p5js dev whether this is a know issue and whether there is a new version coming up addressing this? I couldn't find in any pointers in the release notes ... and @bohnacker said he couldn't find any slow perf issues on the p5 github either. |
@b-g does it make sense to post to the P5js issues? If so, then I'd reference our issue thread here for reference and then reach out to our contacts. Cool? |
@joeyklee please! |
Please see discussion forming here: processing/p5.js#2549 (comment) |
@bohnacker I added |
@joeyklee Gave it a try with the test sketch and the frameRate seems again similar to v0.5.12. I'm not sure what to do. It sounds like the new "friendlyErrors" feature would be something that we want to keep for our sketches. Still, for some of the book sketches it would be nicer to have the frameRate as fast as possible. We should probably pick the sketches by hand where we add this line. |
Just tried the test sketch with the current verision (0.5.16) of p5.min.js. It is another 10 to 20% faster than the corresponding p5.js. So best would be to switch to the min versions. That also would keep the additional line out of our sketches. |
Since using p5js version 0.5.14 the speed of drawing things slowed down noticably on my machine. I haven't measured but sketches that are drawing a lot of elements are about four times slower.
Am I the only one with this problem? I haven't found any similar issues posted on https://github.com/processing/p5.js/issues.
The text was updated successfully, but these errors were encountered: