Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data provider extension points OnAfterXXXError #254

Open
walteralmeida opened this issue Oct 22, 2023 · 2 comments
Open

Add data provider extension points OnAfterXXXError #254

walteralmeida opened this issue Oct 22, 2023 · 2 comments

Comments

@walteralmeida
Copy link
Collaborator

No description provided.

@walteralmeida
Copy link
Collaborator Author

At the moment there is a Exception parameter to the data provider extension event description, for example : OnAfterSaveDataSetEventArgs.Exception

So the same extension point was call in all scenarios => success or failure of the crud operation. This is confusion, add specific extension points.

For the moment I have deactivated calling the extensions in case of errors. See META-254 in frawework code

@walteralmeida
Copy link
Collaborator Author

I have reactivated calling the extensions in case of errors !!
Because the onafter needs to be called after exception to call DisposeAccessAdapter if EnsureAccessAdapter was called OnBefore ...

Reminder : by default onbefore and onafter are not withing the CRUD transaction, unless added (and removed) explicitely.
But that's cumbersome. Better to find a better way that's no so much error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant