-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Docker containers on TravisCI #13
Comments
I have a functioning docker container which currently has an in-container build for testing purposes.However, it can easily be adapted to serve as a base image for CI/CD You can simply use the first part of the Dockerfile to configure the environment. Second part fetches GSSHG and DCW data, third part builds gmt using a simplistic build script. Dependencies will have to be updated for 5.x builds but that was on my road map as well. https://github.com/nc5ng/gmt-docker/blob/master/Dockerfile
P.S. I am also happy to transition the image hierarchy to the GMT organization |
Hi @akshmakov thanks for the help! That sounds like what we needed. Our current scripts are in the Would you like to try doing this yourself? I know you're familiar with Github but I can help with anything you need. We're always glad to have more people involved 😃 We can think about moving the container to a GMT organization later. |
@leouieda Sounds good, Im working on adapting my existing image for CI. Should have a PR to review in the next day or two after I run some tests. |
@leouieda is there any chance Is there a mirror that I can try for GSHHG and DCW datasets? |
Perfect!
@akshmakov yeah, there is something wrong with the ftp downloads. I'm using http to download from the source sites instead of the gmt site. See https://github.com/GenericMappingTools/gmt/blob/master/ci/travis-setup.sh |
…lopment image Target Issue: GenericMappingTools#13
I think we should at least provide following docker images:
|
Leaving this for @leouieda to comment on (he is on travel) as I don't know about docker images... |
@seisman I've kind of changed my mind of the whole Docker thing:
It might be useful to provide GMT enabled Docker images for end users who might want them. But might be too much work to maintain a version for master. Either way, probably better for another issue since this one is specifically for Travis. |
* WIP Batch #13 of longoptions test scripts. * Update psconvert-l2s.sh * Update triangulate-l2s.sh * Update grdfft-l2s.sh * Update sphinterpolate-l2s.sh * Update greenspline-l2s.sh * Update greenspline-l2s.sh --------- Co-authored-by: Paul Wessel <pwessel@hawaii.edu> Co-authored-by: Joaquim <jmfluis@gmail.com>
In #5, we're installing our dependencies on Travis using
apt-get
, which isn't recommended by them. It would be best to have a Docker container that has all of the dependencies installed and we run the tests inside of it. That way we can reproduce the build environment locally if needed.Some help setting this up would be greatly appreciated because we don't have experience with Docker.
cc @bakerunavco
The text was updated successfully, but these errors were encountered: