Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a warning instead a error when requesting a PS file in modern mode #94

Closed
seisman opened this issue Sep 24, 2018 · 3 comments
Closed

Raise a warning instead a error when requesting a PS file in modern mode #94

seisman opened this issue Sep 24, 2018 · 3 comments

Comments

@seisman
Copy link
Member

seisman commented Sep 24, 2018

Full script that generated the error

gmt begin map ps
gmt basemap -R0/10/0/10 -JX5c -Bafg
gmt end

Full error message

psbasemap [ERROR]: Must specify a paper size when requesting a PostScript file
psbasemap [ERROR]: Changing paper size to A4, but we cannot know if this is adequate for your plot.

The script can generate the desired plot correctly. So I think it would be better to raise warnings instead of errors and tell users to change PS_MEDIA if A4 paper size isn't adequate for their plot.
@PaulWessel
Copy link
Member

OK, I can relax the level to warning (requiring -V). We were concerned that this message would not be seen and some user may complain that they got the wrong size. We could add some more wording to the documentation for modern mode to prevent confusion. Would this be OK?

@seisman
Copy link
Member Author

seisman commented Sep 25, 2018

Didn't realize that warnings wouldn't be seen if -V is not used. Adding more wording to clarify this possible confusion is necessary.

PaulWessel added a commit that referenced this issue Dec 30, 2018
@PaulWessel
Explain why modern mode needs to know page size for PS
7aa91cb 
In modern mode, plots are automatically cropped but this is not true if plain PostScript (ps) is requested, in which case a media size is recommended.  This PR adds explanation of this to begin and changes the verbosity level of the error to warning (thus requiring -V to be seen).  Addresses #94.
@PaulWessel PaulWessel mentioned this issue Dec 30, 2018
Merged
joa-quim pushed a commit that referenced this issue Dec 30, 2018
@PaulWessel @joa-quim
Explain why modern mode needs to know page size for PS (#251)
4384942 
In modern mode, plots are automatically cropped but this is not true if plain PostScript (ps) is requested, in which case a media size is recommended.  This PR adds explanation of this to begin and changes the verbosity level of the error to warning (thus requiring -V to be seen).  Addresses #94.
@seisman
Copy link
Member Author

seisman commented Dec 30, 2018

Closed by #251

@seisman seisman closed this as completed Dec 30, 2018
obaney pushed a commit to obaney/gmt that referenced this issue Aug 18, 2021
@leouieda
Add support for pandas.Series in vector_to_vfile (GenericMappingTools…
a4a412d 
…#100)

Get the underlying numpy array from the pandas.Series.
Group the conversion with C contiguous order check in 
gmt.clib.utils.vectors_to_arrays function.

Fixes GenericMappingTools#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seisman @PaulWessel