-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calcab() is never invoked #94
Comments
Not really a bug because it has no impact on the result. |
Related: For pab, it stores all variables in the form of v_a^TP_pv_b. Similarly, |
We appear to have a problem with Calcpab perhaps explaining some of the errors we are getting. After adding NaN checking and matrix range checking we are going out of bounds errors. I expected GSL to show them, but apparently it is not guaranteed.
This is in line Line 245 in 356f528
To me it looks like it is a good idea to compute these values using a different approach - at least to validate results. |
@prasunanand has discovered that param0->ab is never properly calculated in CalcLambda() which is probably erroneous. Calcab() is never called in the code.
The text was updated successfully, but these errors were encountered: