Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logic for handling chapter download/updates #24

Open
genius257 opened this issue Jun 21, 2021 · 1 comment
Open

New logic for handling chapter download/updates #24

genius257 opened this issue Jun 21, 2021 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@genius257
Copy link
Owner

The chapter check/download is top to bottom. In Taadd that means newest to oldest enties, initially.
This produces problems when updates to the Manga is added.
New chapters are currently appearing at the bottom of the list, below the first chapter.
This also screws with the reader experience, as the next and previous page feature acts the same, so trying to go back a page on the first page in chapter 1, will send you to the last page on the newly added chapters.

The solution is tricky, as we need to try and handles things like updates, order changes and possible deleted chapters.
First fix would be to change how we handle chapters in the first place. We need to get them oldest to newest.
This will make future chapters added to appear in the correct order naturally in the database id ordering, avoiding some confusion, without too many changes. (changes to manga API download and the reader should only be updated).
Then there's the issues with deleted chapters. A choice need to be made, if we should delete them, or just mark it as deleted. The second part of this problem, is where in the chapter ordering would an deleted chapter exist?. Ideally a second table with the deleted chapters might appear, and we simply let the user choose the rest in settings. MUCH more work, but less complaints due to different needs.

Finally we have a possible option to make the user able to change the ordering of the chapters manually. This solution should be avoided if possible, as many edge cases could break databases and end up enraging more than helping people.

@genius257 genius257 added bug Something isn't working enhancement New feature or request labels Jun 21, 2021
@genius257
Copy link
Owner Author

One part is fixed, so chapter ordering is correct: 0f0a6ad

@genius257 genius257 self-assigned this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant