Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate native suggestion objects once, and re-use as cached array #45

Open
genius257 opened this issue Mar 4, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@genius257
Copy link
Owner

Generating the native suggestions should be done once, since it's not going to change

//Add all native suggestions
completionItems = completionItems.concat(Object.keys(nativeSuggestions).map<CompletionItem>(nativeSuggestion => ({ //FIXME: Map Object.entries instead
label: nativeSuggestions[nativeSuggestion]!.title || "",
kind: nativeSuggestions[nativeSuggestion]!.kind,
documentation: nativeSuggestions[nativeSuggestion]!.documentation,
detail: nativeSuggestions[nativeSuggestion]!.detail,
})));

@genius257 genius257 added the enhancement New feature or request label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant