Remove unnecessary db methods #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdine
force-pushed
the
fix-parentheses-behavior
branch
from
75fb546
to
b425b13
Compare
asdine
force-pushed
the
remove-unnecessary-db-methods
branch
from
b522c35
to
a56605c
Compare
asdine
force-pushed
the
remove-unnecessary-db-methods
branch
from
a56605c
to
712ef56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewTableandUpdateTableused to be useful when Genji was doing code generation and before the introduction of SQL. They were used to limit the number of lines of generated code.They no longer make sense now as we want to encourage users to use SQL as much as possible.
If there is a need to access tables, there is still the
ViewandUpdatemethods.Please let me know if you think otherwise