feat(core): point selections and conditional encoding #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data flow branch
Happens when changes in parameter values trigger data updates when when initialization is still incomplete.
…package long is a dependency of @gmod/bam.
Make it simpler. If was overly complex because chrom/pos field def resulted in a custom accessor that linearizes the genomic coordinates. Not needed anymore as it is handled by rewiring the data flow.
Collect the logic into a single place
Provide a single dataAccessor that accesses the underlying field or expr
Allows for implementing conditional accessors
Still work in progress but largely works already.
Clicked selections disappeared upong dragging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge PR with tons of refactoring. Only provides single-point selections for now, but can easily extended to support multiple points and intervals. Conditional encoding with selection parameters works by compiling the conditional logic into GLSL code. Thus, it's fast, regardless of the dataset size. Documentation will be written later on.
Anyway, works pretty much identically to Vega-Lite:
https://vega.github.io/editor/#/examples/vega-lite/interactive_bar_select_highlight
point_selections.mp4
Closes #197