Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecoratorView is a hack, replace with an Axis-aware grid view #52

Closed
tuner opened this issue Nov 14, 2021 · 0 comments · Fixed by #100
Closed

DecoratorView is a hack, replace with an Axis-aware grid view #52

tuner opened this issue Nov 14, 2021 · 0 comments · Fixed by #100
Assignees
Labels
refactor Refactor the codebase

Comments

@tuner
Copy link
Member

tuner commented Nov 14, 2021

... that can be specialized into vconcat, hconcat, concat, repeat, and facet (Vega-Lite style faceting, not samples faceting).

Background: Currently, DecoratorView wraps the actual view and handles its axes, view background, and zoom/pan interactions. However, it's difficult to use with faceting and shared axes, etc. Also, in case of facet, state of multiple decorator instances need to be tracked.

The new view could have responsibilities including but not limited to:

  • View titles #28.
  • Axes and Axis grid lines #58
  • Annotations such as
    • the threshold of score-based semantic zoom
    • citations for the shown data
  • Panning and zooming of scales that are shared between the child views
  • Brushing
    • An example: We have multiple genomic tracks, all having a shared x scale and channel. The brush should span all the stacked tracks
@tuner tuner self-assigned this Nov 14, 2021
@tuner tuner added the refactor Refactor the codebase label Dec 7, 2021
@tuner tuner mentioned this issue Jan 27, 2022
@tuner tuner closed this as completed in #100 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant