Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/serialosc: Don't use git-r3 for versioned ebuilds #517

Open
NexAdn opened this issue Jan 3, 2023 · 2 comments
Open

media-sound/serialosc: Don't use git-r3 for versioned ebuilds #517

NexAdn opened this issue Jan 3, 2023 · 2 comments

Comments

@NexAdn
Copy link
Member

NexAdn commented Jan 3, 2023

We should only use git-r3 for the live ebuild, since this allows Manifest checksum generation, distfile caching and downloading the distfiles before building the software.
This might involve some extra work, since upstream facilitates git submodules.
However, it is doable.

@simonvanderveldt
Copy link
Member

Yeah, I believe I did it this way because the upstream source release are just the GitHub generated ones and they unfortunately don't include the git submodule sources.
We could ask upstream and/or create a PR to upstream to make sure releases have an artifact that contains all the relevant sources.

@NexAdn
Copy link
Member Author

NexAdn commented Feb 5, 2023

Actually both submodules are on GitHub, so we can just download tarballs of the respective submodule commits and unpack/link them in the right place in WORKDIR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants