Skip to content

Commit

Permalink
Eliminate kmod dependency
Browse files Browse the repository at this point in the history
Changes to rules were introduced by
06316d9 while kmod support was
introduced in other commits. A ton of commits were made involving kmod
and it is quite clear that it is broken, so we remove it.

This changes our rules to depend on modprobe. As long as the modprobe
binary is in /, and not /usr, udev module loading should function
properly.

Signed-off-by: Richard Yao <ryao@gentoo.org>
  • Loading branch information
ryao committed Nov 17, 2012
1 parent 7412678 commit a91a760
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 153 deletions.
4 changes: 1 addition & 3 deletions configure.ac
Expand Up @@ -38,9 +38,7 @@ if test -z "$GPERF" ; then
AC_MSG_ERROR([*** gperf not found])
fi

# TODO check this --- we don't want kmod necessarily
PKG_CHECK_MODULES(KMOD, [libkmod >= 5])
PKG_CHECK_MODULES(BLKID,[blkid >= 2.20])
# PKG_CHECK_MODULES(BLKID,[blkid >= 2.20])

# Checks for header files.
AC_CHECK_HEADERS(
Expand Down
2 changes: 1 addition & 1 deletion rules/75-probe_mtd.rules
Expand Up @@ -3,6 +3,6 @@
ACTION!="add", GOTO="mtd_probe_end"

KERNEL=="mtd*ro", IMPORT{program}="mtd_probe $devnode"
KERNEL=="mtd*ro", ENV{MTD_FTL}=="smartmedia", IMPORT{builtin}="kmod load sm_ftl"
KERNEL=="mtd*ro", ENV{MTD_FTL}=="smartmedia", RUN+="@sbindir@/modprobe -bv sm_ftl"

LABEL="mtd_probe_end"
12 changes: 6 additions & 6 deletions rules/80-drivers.rules
Expand Up @@ -2,11 +2,11 @@

ACTION=="remove", GOTO="drivers_end"

DRIVER!="?*", ENV{MODALIAS}=="?*", IMPORT{builtin}="kmod load $env{MODALIAS}"
SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="SD", IMPORT{builtin}="kmod load tifm_sd"
SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="MS", IMPORT{builtin}="kmod load tifm_ms"
SUBSYSTEM=="memstick", IMPORT{builtin}="kmod load ms_block mspro_block"
SUBSYSTEM=="i2o", IMPORT{builtin}="kmod load i2o_block"
SUBSYSTEM=="module", KERNEL=="parport_pc", RUN{builtin}="kmod load ppdev"
DRIVER!="?*", ENV{MODALIAS}=="?*", RUN+="@sbindir@/modprobe -bv $env{MODALIAS}"
SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="SD", RUN+="@sbindir@/modprobe -bv tifm_sd"
SUBSYSTEM=="tifm", ENV{TIFM_CARD_TYPE}=="MS", RUN+="@sbindir@/modprobe -bv tifm_ms"
SUBSYSTEM=="memstick", RUN+="@sbindir@/modprobe -bv --all ms_block mspro_block"
SUBSYSTEM=="i2o", RUN+="@sbindir@/modprobe -bv i2o_block"
SUBSYSTEM=="module", KERNEL=="parport_pc", RUN+="@sbindir@/modprobe -bv ppdev"

LABEL="drivers_end"
1 change: 0 additions & 1 deletion src/test/Makefile.am
Expand Up @@ -16,6 +16,5 @@ test_udev_SOURCES = \
test_udev_LDADD = \
libudev-core.la \
$(BLKID_LIBS) \
$(KMOD_LIBS) \
$(SELINUX_LIBS)

7 changes: 2 additions & 5 deletions src/udev/Makefile.am
Expand Up @@ -52,7 +52,6 @@ libudev_core_la_SOURCES = \
udev-builtin-firmware.c \
udev-builtin-hwdb.c \
udev-builtin-input_id.c \
udev-builtin-kmod.c \
udev-builtin-net_id.c \
udev-builtin-path_id.c \
udev-builtin-usb_id.c \
Expand All @@ -76,13 +75,11 @@ libudev_core_la_SOURCES = \

libudev_core_la_CFLAGS = \
$(AM_CFLAGS) \
$(BLKID_CFLAGS) \
$(KMOD_CFLAGS)
$(BLKID_CFLAGS)

libudev_core_la_LIBADD = \
$(top_srcdir)/src/libudev/libudev-private.la \
$(BLKID_LIBS) \
$(KMOD_LIBS)
$(BLKID_LIBS)

if HAVE_ACL
libudev_core_la_SOURCES += \
Expand Down
134 changes: 0 additions & 134 deletions src/udev/udev-builtin-kmod.c

This file was deleted.

1 change: 0 additions & 1 deletion src/udev/udev-builtin.c
Expand Up @@ -35,7 +35,6 @@ static const struct udev_builtin *builtins[] = {
[UDEV_BUILTIN_FIRMWARE] = &udev_builtin_firmware,
[UDEV_BUILTIN_HWDB] = &udev_builtin_hwdb,
[UDEV_BUILTIN_INPUT_ID] = &udev_builtin_input_id,
[UDEV_BUILTIN_KMOD] = &udev_builtin_kmod,
[UDEV_BUILTIN_NET_ID] = &udev_builtin_net_id,
[UDEV_BUILTIN_PATH_ID] = &udev_builtin_path_id,
[UDEV_BUILTIN_USB_ID] = &udev_builtin_usb_id,
Expand Down
2 changes: 0 additions & 2 deletions src/udev/udev.h
Expand Up @@ -139,7 +139,6 @@ enum udev_builtin_cmd {
UDEV_BUILTIN_FIRMWARE,
UDEV_BUILTIN_HWDB,
UDEV_BUILTIN_INPUT_ID,
UDEV_BUILTIN_KMOD,
UDEV_BUILTIN_NET_ID,
UDEV_BUILTIN_PATH_ID,
UDEV_BUILTIN_USB_ID,
Expand All @@ -162,7 +161,6 @@ extern const struct udev_builtin udev_builtin_btrfs;
extern const struct udev_builtin udev_builtin_firmware;
extern const struct udev_builtin udev_builtin_hwdb;
extern const struct udev_builtin udev_builtin_input_id;
extern const struct udev_builtin udev_builtin_kmod;
extern const struct udev_builtin udev_builtin_net_id;
extern const struct udev_builtin udev_builtin_path_id;
extern const struct udev_builtin udev_builtin_usb_id;
Expand Down

0 comments on commit a91a760

Please sign in to comment.