Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elogind and eudev #145

Closed
udeved opened this issue May 12, 2017 · 10 comments
Closed

elogind and eudev #145

udeved opened this issue May 12, 2017 · 10 comments

Comments

@udeved
Copy link

udeved commented May 12, 2017

If elogind is used in combination with eudev-3.2.2, an udev error is logged.

May 8 08:00:55 manjaro kernel: udevd[596]: RUN{builtin}: 'uaccess' unknown /usr/lib/udev/rules.d/73-seat-late.rules:15

I quote from another user who reported the same issue:

https://github.com/systemd/systemd/blob/master/src/udev/udev-builtin.c#L45

for eudev one would need to get the uaccess code in and then you need to add the --acl option
to eudev .. just not sure eudev upstream want this.

elogind/elogind#10 (comment)

@Yamakuzure
Copy link

The code needed isn't much, it just updates user ACLs on devices.

See:
https://github.com/systemd/systemd/blob/master/src/udev/udev-builtin-uaccess.c

The offending rule that triggers the error is this one:
https://github.com/elogind/elogind/blob/master/src/login/73-seat-late.rules.in#L15

@blueness
Copy link
Contributor

blueness commented Sep 3, 2017

I've resisted putting acl's into eudev, but it looks like you guys need it. I'll play with it a bit and try to get something out in v3.3

@CameronNemo
Copy link

CameronNemo commented Sep 14, 2017

FYI I placed a small bounty on this bug, thanks for your work @blueness

@josch09
Copy link

josch09 commented Nov 1, 2017

@Yamakuzure
Copy link

Well... if printing an error by openrc did crash his broadcom wl driver, there is something seriously wrong with his machine.
That rule failing can't likely be the cause. Removing that file only stopped openrc to print an error.

And for the record, I am using the broadcom wl driver ("broadcom-sta"), too, and it doesn't segfault on my machine. (But then, there might be differences between the broadcom-sta ebuild install and the Manjaro dmks install? No idea...)

Having correct ACLs on device nodes is a nice-to-have feature, but I am still not convinced, that it is that mission critical. (Maybe I just know too little about it...)

@CameronNemo
Copy link

@arthurt has proposed a branch for elogind to do the ACL changes itself, so eudev likely will not need to include the uaccess helper to play nice with elogind once that is merged and released

@blueness
Copy link
Contributor

@CameronNemo Okay, let me know if there's anything I need to do on my end. I like this design direction.

@CameronNemo
Copy link

CameronNemo commented Mar 26, 2018

This has been fixed in the recent release of elogind. Should this issue be closed?

If so, @arthurt you can claim the $8 bounty for this issue!

elogind/elogind#10 (comment)

@blueness
Copy link
Contributor

yeah this can be closed.

@arthurt
Copy link

arthurt commented May 20, 2018

If so, @arthurt you can claim the $8 bounty for this issue!

Can I claim it please, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants