Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_* should always use default values when their attributes are not explicitly specified #46

Closed
tampakrap opened this issue Feb 20, 2013 · 5 comments

Comments

@tampakrap
Copy link

package_keywords { 'app-admin/puppet':
  keywords => '~amd64',
  ensure => present,
}

The above creates an entry app-admin/puppet ~amd64 in /etc/portage/package.keywords/default. On a second run:

package_keywords { 'app-admin/puppet':
  ensure => present
}

The above does nothing, while I would expect for it to remove the keywords from the previously created entry. The workaround to this is to write:

package_keywords { 'app-admin/puppet':
  keywords => '',
  ensure => present,
}
@tampakrap
Copy link
Author

the same behavior happens for all package_* types with any attribute: version, ensure, keywords. So we need to enforce it to use a default value when the attribute is not specified. (I am updating the title of this report accordingly)

@tampakrap
Copy link
Author

The same issue is happening when I specify no version on first run, but specify a version on the second run

@vikraman
Copy link

vikraman commented Oct 5, 2013

Still affects package_mask and package_unmask, due to the same issue as #51

@tampakrap
Copy link
Author

so is it a duplicate?

@vikraman
Copy link

vikraman commented Oct 5, 2013

Partially fixed, remaining issue is duplicate of #51

@vikraman vikraman closed this as completed Oct 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants