Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in documentation / examples #2

Closed
tripu opened this issue Dec 13, 2017 · 1 comment
Closed

Fix errors in documentation / examples #2

tripu opened this issue Dec 13, 2017 · 1 comment

Comments

@tripu
Copy link

tripu commented Dec 13, 2017

(cf martinsbalodis#202)

It was already mentioned on that PR upstream that the package name is wrong in the README (and therefore on npm, too): it should be web-scraper-headless, not webscraper-headless.

Apart from that, I don't get why the only example is suggesting testing against http://test.lv/. It's a particularly ugly and weird (HTML 4.01) web page…

Anyway, the suggested selector doesn't find anything on the page:

selectors: [
  {
    'id': 'a',
    'selector': '#scraper-test-one-page a',
    'multiple': false,
    type: 'SelectorText',
    'parentSelectors': [
      '_root'
    ]
  }
]

Am I doing anything wrong?

Can we have a few examples that are correct and representative?

@furstenheim
Copy link

Thanks tripu, I've fixed the typo on the require.

As for the example, it was a mock example (straight from the tests) to avoid relying on a third web. It was indeed confusing, so I've changed it with a real example. e3e7de1

Hope that it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants