Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual customisation feedback #18

Open
missinglink opened this issue Aug 4, 2021 · 0 comments
Open

visual customisation feedback #18

missinglink opened this issue Aug 4, 2021 · 0 comments

Comments

@missinglink
Copy link
Contributor

missinglink commented Aug 4, 2021

I've been playing around with doing some zany visual customisation which highlighted some minor issues with the templating/css vars.

None of this is urgent to fix, I'm just writing it down here so I don't forget ;)

  • currently there is no way of completely disabling the placeholder text, a workaround is to use a single space " "
  • when using custom 'row' templates the <li> no longer has the result-item and result-item-active classes, this makes it difficult/impossible to style the full width/height background-color of each row. [edit] this was my fault
  • allow implementing white-space: nowrap; overflow: hidden; with optional text-overflow: ellipsis;, this is not possible by default, it can be achieved with row templates but requires nesting an additional <span> otherwise the icon width throws off the ellipsis calc. It would be even better if this didn't require using the private API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant