Incorrect parsed name from Google Maps api

[jongotlin]

Searching for Pershagen returns the following json
https://maps.googleapis.com/maps/api/geocode/json?address=Pershagen&key=xxx

{
   "results" : [
      {
         "address_components" : [
            {
               "long_name" : "Pershagen",
               "short_name" : "Pershagen",
               "types" : [ "locality", "political" ]
            },
            {
               "long_name" : "Södertälje",
               "short_name" : "Södertälje",
               "types" : [ "postal_town" ]
            },
            {
               "long_name" : "Stockholm County",
               "short_name" : "Stockholm County",
               "types" : [ "administrative_area_level_1", "political" ]
            },
            {
               "long_name" : "Sweden",
               "short_name" : "SE",
               "types" : [ "country", "political" ]
            },
            {
               "long_name" : "151 39",
               "short_name" : "151 39",
               "types" : [ "postal_code" ]
            }
         ],
         "formatted_address" : "151 39 Pershagen, Sweden",
         "geometry" : {
            "location" : {
               "lat" : 59.14664239999999,
               "lng" : 17.6511284
            },
            "location_type" : "APPROXIMATE",
            "viewport" : {
               "northeast" : {
                  "lat" : 59.15236419999999,
                  "lng" : 17.6671358
               },
               "southwest" : {
                  "lat" : 59.1409196,
                  "lng" : 17.635121
               }
            }
         },
         "place_id" : "ChIJV_Hb5dUSX0YRULaMsvX-AAo",
         "types" : [ "locality", "political" ]
      }
   ],
   "status" : "OK"
}

Using the google maps provider I get the following object. The phrase Pershagen is omitted.

Searching for the similar area Ronna I get a more correct object.

When looping over address components Pershagen is first set but then overridden by Södertälje.

Reversing the array on L235 in GoogleMaps.php returns a more accurate result.

+foreach (array_reverse($result->address_components) as $component) {
-foreach ($result->address_components as $component) {

Not at all sure how this will affect other results!

[alanpoulain]

It's because of the order of these two lines:

Geocoder/src/Provider/GoogleMaps/GoogleMaps.php

Lines 295 to 296 in c2d2c3b

	case 'locality':
	case 'postal_town':

Maybe postal_town should be before locality?

[jongotlin]

@alanpoulain That won't affect the result unfortunately.

[jbelien]

Thanks for the notice !
We'll need to test for address all over the world to (maybe) improve the process of locality and postal_town.
I'll try to do that ASAP.

@jongotlin For "Pershagen" search, if "Pershagen" is the locality, what should "Södertälje" be ?

[jongotlin]

Ideally Pershagen would be a sub locality and Södertälje locality but thats not what the Google response says.

Can we have Södertälje in list of admin levels?

[jbelien]

Can we have Södertälje in list of admin levels?

The issue is to keep a logic that works for all countries.
We only put administrative_area_level_1...5 in the admin levels list.

[jongotlin]

Aha, understand. Maybe skip Södertälje in this case. The data from Google is not really correct. I think the rule here should be "If locality is set it should not be overridden by postal_town".

[jbelien]

The goal of this library is to create a layer on top of (reverse) geocoding API, not fix/process/mess with the data returned by the API.

I think the rule here should be "If locality is set it should not be overridden by postal_town".

I'll make some tests for other countries in the world to see if that applies.
We won't make changes that will affect every country "just" to fix a locality issue in Sweden.

[jongotlin]

Yes, understand and agree with that. However, overriding a value like this doesn't seems correct.