Jannes: second edition

[Nowosad]

The comments below are based on my reading of the whole book. Feel free to ignore the ones you think are not useful:

Chapter 4:

• "To do so, we can weight the distance with elevation so that each additional altitudinal meter ‘prolongs’ the Euclidean distance" -- can you add a sample code for this (e.g., using the nz_elev data)?

Chapter 12:

• Maybe it would be a good idea to add comments to the packages attached at the start of the chapter (v. shortly what do they do)
• I think we discussed that in the past: I think it would be good to add a note at the end of the chapter about how to make spatial predictions from mlr3 model. I got a question about this a few times.

Chapter 14:

• "which tries repeatedly (three times in this case) to download the data". Based on the code, is it not two times?

Chapter 15:

• Chapters 13 and 14 both have similar lists at the beginning, explaining the rest of the chapter and giving cross-references to all of the sections in these chapters (see https://r.geocompx.org/transport#introduction-7 and https://r.geocompx.org/location#case-study. I think it would be nice to have such a list in Chapter 15.

[jannes-m]

Thanks for the suggestions @Nowosad, these are very much appreciated and I will take care of them.

[Robinlovelace]

Looking at the above comments, the most important seems to be

I think we discussed that in the past: I think it would be good to add a note at the end of the chapter about how to make spatial predictions from mlr3 model. I got a question about this a few times.

That sounds in-demand. Some of them may be 'wontfix' issues.

[jannes-m]

Yes, I will take care of these this week! And I think in chapter 12 we already tell the reader to look at c15 for instructions how to do spatial predictions but maybe we have to emphasize this even more or so say so in the beginning of the chapter.

[Robinlovelace]

Big thumbs up to that, thanks Jannes!

[jannes-m]

@Nowosad you are absolutely right with regard to the while loop iterations. I was counting also the first try outside of the while loop but yes, as it stands, it was simply wrong. Hence, I have updated the text accordingly. Thanks for spotting!

[jannes-m]

@Nowosad Regarding the computation of raster distance weighted by some other variable, I have pointed the reader to E8 and E9 at the end of chapter 4 where we are doing exactly this.

[Nowosad]

#1054