Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

think about removing solidus initial condition #1528

Closed
jdannberg opened this issue May 9, 2017 · 1 comment
Closed

think about removing solidus initial condition #1528

jdannberg opened this issue May 9, 2017 · 1 comment

Comments

@jdannberg
Copy link
Contributor

There is an initial temperature model called "solidus" that reads in a file to be used as the initial temperature and adds some spherical harmonic perturbation. Initially, it was used to generate an initial temperature model for early Mars after the freezing of the magma ocean.

In principal, we have the same functionality in other plugins, and the name of this plugin is misleading now that we have melt migration and melting models that could compute a solidus that is consistent with the material model (which is also something that would be useful to have as a temperature initial condition).

We should discuss what to do with this file and where to move it best if we want to remove it from the main code (test? cookbooks/future?).

@SiqiZhang: You created this model, do you have an opinion on this? Did you use this file for some of your models and would be willing to write a cookbook for it? Otherwise, I would vote for moving it to a test.

@SiqiZhang
Copy link
Contributor

I agree that the current state of this plugin may not be so useful for other modelers. I have no objection of moving it to a test.
However, we could improve it to use mantle adiabatic and limit it with mantle solidus (mainly for the upper mantle) get from material model. This may make it more useful for other mantle models.

@jdannberg jdannberg added this to the 2.0 milestone Apr 27, 2018
@jdannberg jdannberg added this to Coding style & Cleanup in Issue tracker Apr 27, 2018
@jdannberg jdannberg removed this from Coding style & Cleanup in Issue tracker Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants