Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prm section names in benchmark folders #1638

Closed
bangerth opened this issue May 13, 2017 · 4 comments
Closed

Fix prm section names in benchmark folders #1638

bangerth opened this issue May 13, 2017 · 4 comments

Comments

@bangerth
Copy link
Contributor

benchmarks/include/adaptive.prm.base still has this section:

subsection Initial temperature 
  set Model name = perturbed box
end

and so do several of the other benchmark input files. These got forgotten when we renamed these section names recently and will not work any more right now.

@alarshi is taking care of the one file mentioned above, but we need to test and convert the other ones as well.

@hlokavarapu
Copy link
Contributor

Looking into making the conversion of parameter subsections.

@hlokavarapu
Copy link
Contributor

After going through the benchmarks, I found that none of the parameter files were out of date other than benchmarks/inclusion/global.prm.base and benchmarks/inclusion/adaptive.prm.base

My guess is that because these files do not end with the extension .prm, they were not updated.

@gassmoeller
Copy link
Member

Yes that was me. I did only update files ending on .prm. Thinking about it there might be other files. Working on a PR

@gassmoeller
Copy link
Member

Closed by #1646 and #1633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants