Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_current_constraints is called twice at the start of time step 0 #2129

Open
jdannberg opened this issue Mar 14, 2018 · 0 comments
Open

Comments

@jdannberg
Copy link
Contributor

At the moment, we call compute_current_constraints() twice at the start of time step 0 (and for each adaptive refinement of time step 0), once in setting the initial conditions, and then another time in start_timestep. This is not wrong, it is just a bit confusing and probably unnecessary work. So it would make sense to not call compute_current_constraints() in start_timestep if the time step number is zero. However, as @gassmoeller pointed out to me, we should first think about what happens in the case of restarting a computation and test if we run into any problems there before making this change.

@jdannberg jdannberg added this to Bugfixes in Issue tracker Apr 27, 2018
@jdannberg jdannberg moved this from Bugfixes to Performance in Issue tracker Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issue tracker
  
Coding style & Cleanup
Development

No branches or pull requests

1 participant