Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the sign of ascii gravity and boundary velocity #2605

Closed
bartniday opened this issue Aug 13, 2018 · 2 comments
Closed

Changing the sign of ascii gravity and boundary velocity #2605

bartniday opened this issue Aug 13, 2018 · 2 comments

Comments

@bartniday
Copy link
Contributor

bartniday commented Aug 13, 2018

The ascii data plugins for gravity and boundary velocity don't allow you to change the sign (for backward advection) without making a separate input file, since the built-in scale factor is required to be >= 0.

Checking that the scale factor is non-negative makes sense for other ascii data plugins, but it would be nice to have a way of inverting gravity and boundary velocity within the parameter file.

@gassmoeller
Copy link
Member

I agree. In fact I do not think any of the ascii data plugins should have that limitation any more (even the temperature could be a perturbation to another temperature plugin and could contain negative values). Fixing this is as simple as changing Double(0) to Double() as pattern for the parameter in line 1765 in utilities.cc (in the call to declare entry for the parameter Scale factor). If you have the time please go ahead and submit this as a pull request. Bonus points if you update the documentation text for this parameter (or also the others) as it was originally written for boundary velocities, but is now used for arbitrary input data.

@bartniday
Copy link
Contributor Author

I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants