Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate comics are coming back #31

Open
geoffrich opened this issue Jan 16, 2023 · 0 comments
Open

Duplicate comics are coming back #31

geoffrich opened this issue Jan 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@geoffrich
Copy link
Owner

I'm still seeing duplicate messages in the logs. This could mean other comics are missing.

Examples: 2007 (55 duplicates), 1996 (7 duplicates)

console.log(arr.length - deduped.length, 'duplicates');

Last time this was related to the order between pages:

// when ordering by other fields (e.g. date), the API response is missing some comics. So don't change this without testing!
// to check if comics are missing, order a year alphabetically and check for missing issue numbers
// if duplicates are found, this likely means another comic is missing.
orderBy: 'modified'

Shot in the dark: maybe #16 would help resolve this

@geoffrich geoffrich added the bug Something isn't working label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant