Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically determine node version #48

Closed
geoffrich opened this issue Jun 10, 2022 · 3 comments · Fixed by #144
Closed

Dynamically determine node version #48

geoffrich opened this issue Jun 10, 2022 · 3 comments · Fixed by #144

Comments

@geoffrich
Copy link
Owner

#47 updated the adapter to target Node 16 instead of 12. This is good, but it would be better if we could allow the user to specify which node version to use. Otherwise, they'll be tied to the adapter Node version.

Here's how adapter-vercel does it:

https://github.com/sveltejs/kit/blob/3dae8e702641b5ee762b1892b7b7aa90e1c19a7c/packages/adapter-vercel/index.js#L388-L399

@geoffrich
Copy link
Owner Author

geoffrich commented Mar 16, 2023

This could be solved using route-level config like the Vercel adapter: https://kit.svelte.dev/docs/adapter-vercel#deployment-configuration edit: scratch that, not sure if you can have two Azure functions with different node versions in SWA. if this ends up being a config option it should be global for the app.

@BernhardAuer
Copy link

Any news on this? I'd like to use node18 in SWA. Would it be possible to extend the customization level of the staticwebapp.config.json as proposed in #66 ?

@geoffrich
Copy link
Owner Author

Thanks for the bump @BernhardAuer - this was a quick feature add that is available in 0.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants