Suggested fix(inequality filter) #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSolati
requested changes
Jan 19, 2019
src/GeoQuery.ts
Outdated
| @@ -139,6 +140,9 @@ export class GeoQuery { | |||
| opStr: GeoFirestoreTypes.WhereFilterOp, | |||
| value: any | |||
| ): GeoQuery { | |||
| // True if inequality filter is used | |||
| this._ineq = (opStr !== '==' && opStr !== 'array-contains') ? true : this._ineq; | |||
There was a problem hiding this comment.
Can we yank this, I'd rather go straight back to using return this._query.orderBy('g').startAt(query[0]).endAt(query[1]) as GeoFirestoreTypes.web.Query;
So any inequality checks can be removed.
There was a problem hiding this comment.
Done.
The argument was that by using where() instead of startAt, the "orderBy query modifiers" could be used by devs. Therefore I wanted to respect that change. However I agree and with the " inequality checks" the behaviour becomes inconsistent.
|
It became apparent that this PR probably does not have any added value 😬 see #78 |
MichaelSolati
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #78