Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master key renewal may silently fail #5

Closed
dahlia opened this issue Jan 24, 2015 · 0 comments
Closed

Master key renewal may silently fail #5

dahlia opened this issue Jan 24, 2015 · 0 comments
Assignees
Labels

Comments

@dahlia
Copy link
Contributor

dahlia commented Jan 24, 2015

The current implementation of master key renewal is done with SFTP write operation, and it implicitly overwrites the previous authorized_keys file. Overwriting operation might not be atomic, and may consist of two operations instead: remove existing one and write a new file. There’s a case that only first half of operations is successfully done, and then the remained half fails e.g. condition that there’s no free space in the disk.

All authorized_keys files are supposed to be confirmed whether they are well written once again before promoting the new key as the master key.

@dahlia dahlia added the bug label Jan 24, 2015
@dahlia dahlia closed this as completed in 57dce44 Feb 13, 2015
@dahlia dahlia self-assigned this Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant