Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document units #1

Closed
nickolasclarke opened this issue Feb 6, 2018 · 5 comments
Closed

document units #1

nickolasclarke opened this issue Feb 6, 2018 · 5 comments

Comments

@nickolasclarke
Copy link

nickolasclarke commented Feb 6, 2018

It is unclear what units the different pollutants are reported in. While I can infer the units by looking at other sources, it would be good to add those explicitly to the converted XML or at least to the JSON. Can you help confirm the units being reported?

@geoinsights
Copy link
Owner

The source data stream does not contain the units for each pollutant. However, through verifying some cases from the source web site(CNEMC http://www.cnemc.cn/), you can infer the units:
For pollutants PM2.5, PM10, SO2,NO2, O3, the unit is μg/m^3.
For CO, the unit is mg/m^3. @nickolasclarke

@nickolasclarke
Copy link
Author

@geoinsights yes, however, I do think it would be valuable to include this information as part of the project no? I can provide a PR if needed. I'll be including it on my fork regardless.

@geoinsights
Copy link
Owner

@nickolasclarke You are right, the unit information is valuable for the project. I will appreciate it if you could provide a pull request. Thanks a lot for reminding me. 🙂

@nickolasclarke
Copy link
Author

@geoinsights sounds great.

@jflasher
Copy link
Contributor

@geoinsights thanks for this work! Where do you think the right place to add the units would be? Because it's not included in the original stream, I'm not sure it should be added to thedata.xml. I think maybe it should just be added in xml2json.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants