New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document units #1
Comments
The source data stream does not contain the units for each pollutant. However, through verifying some cases from the source web site(CNEMC http://www.cnemc.cn/), you can infer the units: |
@geoinsights yes, however, I do think it would be valuable to include this information as part of the project no? I can provide a PR if needed. I'll be including it on my fork regardless. |
@nickolasclarke You are right, the unit information is valuable for the project. I will appreciate it if you could provide a pull request. Thanks a lot for reminding me. 🙂 |
@geoinsights sounds great. |
@geoinsights thanks for this work! Where do you think the right place to add the units would be? Because it's not included in the original stream, I'm not sure it should be added to the |
It is unclear what units the different pollutants are reported in. While I can infer the units by looking at other sources, it would be good to add those explicitly to the converted XML or at least to the JSON. Can you help confirm the units being reported?
The text was updated successfully, but these errors were encountered: