隠しディレクトリや許可された拡張子以外は tile.json に含めない #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keichan34
requested changes
Dec 15, 2023
そうですよね。。直下に合ったほうがお客さん的に分かりやすいかと思いつつも、data/ に入れてしまえばそんな心配もなくなるので悩んでました。 |
|
でも分けたほうが分かりやすいかな。。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #28
Action を呼び出す側で、ルートディレクトリを指定した場合などに、.github や README.md 等を Tiles.json に含めてしまうので、許可した拡張子と通常のディレクトリのみを含めるようにしました。
https://github.com/geolonia/smartcity-data-upload-template