Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 compatibility #20

Open
joevaugh4n opened this issue Feb 21, 2024 · 13 comments
Open

Storybook 8 compatibility #20

joevaugh4n opened this issue Feb 21, 2024 · 13 comments

Comments

@joevaugh4n
Copy link

Hey @geometricpanda! I’m reaching out from the core SB team :)

Storybook 8 (our next major release) is coming soon, and it introduces some breaking changes that your addon might need to account for.

We’ve listed all the key changes in a new Storybook 8 migration guide, and we’d encourage you to check it out and see if your addon is impacted.

We also have an addons channel in our Discord community, which we’d like to use to better communicate with addon authors in the future. If you’re not part of the server, consider joining here and message me (@joevaugh4n) so that I can give you the addon creator role! If you’re already in the server, please just ping me and I’ll respond to you there.

Thanks for being a part of our addon community!

Joe

@JamesIves
Copy link
Contributor

JamesIves commented Mar 12, 2024

Just attempted a version 8 upgrade, and I'm seeing this error flagged by storybook-addon-badges:

❯ npx storybook@latest doctor
🩺 The doctor is checking the health of your Storybook..
╭ Incompatible packages found ───────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                    │
│   The following packages are incompatible with Storybook 8.0.0 as they depend on different major versions of Storybook packages:   │                                                   │
│   - @geometricpanda/storybook-addon-badges@2.0.2                                                                                   │                                                                              │                                                                                             │
│                                                                                                                                    │
│                                                                                                                                    │
│   Please consider updating your packages or contacting the maintainers for compatibility details.                                  │
│   For more on Storybook 8 compatibility, see the linked GitHub issue:                                                              │
│   https://github.com/storybookjs/storybook/issues/26031                                                                            │
│                                                                                                                                    │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

@carlwelchyubico
Copy link

carlwelchyubico commented Mar 27, 2024

I'm able to successfully display Badges, But I see this error when starting up 8.04

15% building 0/2 entries 62/161 dependencies 4/42 modulesWARN Failed to parse .storybook/preview.ts with react-docgen. Please use the below error message and the content of the file which causes the error to report the issue to the maintainers of react-docgen. https://github.com/reactjs/react-docgen
SyntaxError: ./.storybook/preview.ts: Unexpected token, expected "}" (37:18)

  35 |     },
  36 |     badgesConfig: <BadgesConfig>{
> 37 |       [BADGE.BETA]: {
     |                   ^
  38 |         styles: {
  39 |           backgroundColor: '#FFF',
  40 |           borderColor: '#018786',

@math-bourgeois
Copy link

Do we know when a new release will be created to include this fix?

@Freytag
Copy link

Freytag commented Apr 26, 2024

I pulled down the latest code and noticed that this should be resolved with whats on main, looks like we're just waiting for a successful release to happen.

@fpcoutinho
Copy link

Any news on the release of the new version? 😔
It looks like it broke on the yarn publishing process.

@andrew-y0u
Copy link

@geometricpanda, could you release the new version by any chance?

@geometricpanda
Copy link
Owner

Yeah I'll give it a try when I get to my laptop. I fear it's gonna end in debugging however

@sense-design
Copy link

We would love to have the 8.x compatibility for a current project we have set up.

@andrew-y0u
Copy link

🆙

@drjonnicholson
Copy link

drjonnicholson commented Jun 23, 2024

Also looking forward to v8 compatibility :) @geometricpanda any progress?

@alico-cra
Copy link

Happy to test out if needed, excited for the release!

@Freytag
Copy link

Freytag commented Jun 27, 2024

I'm pretty sure it was just a release issues that happened. As i mentioned in this issue #25

@heddal
Copy link

heddal commented Jun 28, 2024

Would also appreciate v8 compatibility 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests