Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test refactoring geometry_git to use vcs_info #245

Closed
jedahan opened this issue Jan 2, 2019 · 2 comments
Closed

test refactoring geometry_git to use vcs_info #245

jedahan opened this issue Jan 2, 2019 · 2 comments

Comments

@jedahan
Copy link
Member

jedahan commented Jan 2, 2019

vcs_info might be faster, might be slower.

How can we benchmark it?

Even if its 20% slower, does it help reduce complexity?

@frm
Copy link
Member

frm commented Jan 15, 2019

How can we benchmark it?

Define a set of large and smaller repos and maybe use zprof?

Even if its 20% slower, does it help reduce complexity?

This is a tradeoff I'm willing to have if it's maintainable for us and usable at the same time. It might not even be fast by default but configurable to be fast - e.g. the user disables certain features if they want speed.

@jedahan jedahan closed this as completed Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants