Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliased commands may break geometry #63

Closed
desyncr opened this issue Dec 14, 2016 · 2 comments
Closed

Aliased commands may break geometry #63

desyncr opened this issue Dec 14, 2016 · 2 comments
Labels

Comments

@desyncr
Copy link
Member

desyncr commented Dec 14, 2016

As per #59. Aliased commands may break/change geometry inner workings.

Avoid this with a similar approach to zsh-users/zsh-syntax-highlighting#390:

At the top:

# Save aliases into a variable and remove/unalias everything
zsh_highlight__aliases=`alias -L`
builtin unalias -m '*'

At the bottom:

# Restore aliases & kill global variable
eval "$zsh_highlight__aliases"
builtin unset zsh_highlight__aliases
@frm
Copy link
Member

frm commented Jan 7, 2017

As I mentioned in #59 looking through the code there don't seem to be many instances of possible aliased commands.

A possible solution would be prepending with command rm or \rm, even though that makes the code messy.

Unaliasing and aliasing over and over is going to affect render time, isn't it?

@desyncr
Copy link
Member Author

desyncr commented Jan 7, 2017

I guess this issue was left hanging out since this issue was resolved with \rm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants