Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CSV handler #77

Closed
mattiagiupponi opened this issue Aug 5, 2022 · 0 comments
Closed

Create CSV handler #77

mattiagiupponi opened this issue Aug 5, 2022 · 0 comments
Assignees

Comments

@mattiagiupponi
Copy link
Contributor

mattiagiupponi commented Aug 5, 2022

As you know the new importer misses the CSV handler. We were waiting to implement a solution that should replace the upload steps that we have now, where the lat/lon column can be selected at upload time.
We cannot afford to implement a new UI for the custom selection of columns, so our proposal would be the following:

preconfigure the CSV handler with OGR X_POSSIBLE_NAMES="x,lon*" and Y_POSSIBLE_NAMES="y,lat*" options
accept a companion "*.csvt" file, as supported by the OGR CSV driver
This solution would provide an alternative that's not too expensive and complex to implement, and gives the opportunity to remove the current upload system (at the moment it's still required only for CSV files).

I'm not against the solution based on Tabular Data Resource and VSI.
I think all these options could coexist, letting the handler pick up the best depending on the provided files, with X_POSSIBLE_NAMES and Y_POSSIBLE_NAMES preconfigurations as a fallback.

What's your opinion?

GeoNode/geonode#8714 (comment)

mattiagiupponi added a commit that referenced this issue Feb 14, 2023
mattiagiupponi added a commit that referenced this issue Feb 14, 2023
mattiagiupponi added a commit that referenced this issue Feb 14, 2023
mattiagiupponi added a commit that referenced this issue Mar 3, 2023
giohappy added a commit that referenced this issue Mar 3, 2023
mattiagiupponi added a commit that referenced this issue Mar 27, 2023
* [Fixes #148] sld file is not handled during the overwrite flow (#149)
* [Fixes #148] sld file is not handled during the overwrite flow
* [Fixes #145] improve status evaluation if other tasks are still running (#146)
* [Fixes #154] Add basic handler structure (#155)
* [Fixes #77] Add CSV handler

---------

Co-authored-by: Giovanni Allegri <giovanni.allegri@gmail.com>
mattiagiupponi added a commit that referenced this issue Apr 12, 2023
* [Fixes #148] sld file is not handled during the overwrite flow (#149)

* [Fixes #148] sld file is not handled during the overwrite flow

* [Fixes #145] improve status evaluation if other tasks are still running (#146)

* [Fixes #154] Add basic handler structure (#155)

* [Fixes #77] Add CSV handler

* [Fixes #77] Add CSV handler

* [Fixes #77] Add CSV handler

* [Fixes #77] Add CSV handler

* [Fixes #77] Update readme with the supported columns for CSV

* [Fixes #77] Update readme with the supported columns for CSV

* add possible column name in ogr2ogr command

* [Fixes #77] Fix pr comments

* Allow nonspatial layer import (#159)

* Allow nonspatial layer import

This commit includes minor changes to the importer to allow layers
without geometry information. This includes two things: First, we relax
the assumption that a geometry column must be present and let the
actual handler implementation decide to add the dimension lco option.
Second, we introduce a prepare_import step to the interface. Here, any
customizations can be done before the actual import starts.

Actual implementation of the datapackage handler moved to the contribs
repository and can be installed as mere dependency.

* Tests if prepare_import is called

---------

Co-authored-by: Giovanni Allegri <giovanni.allegri@gmail.com>
Co-authored-by: Henning Bredel <h.bredel@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant