Skip to content

Commit

Permalink
- Improve Thumbnail method so that it can include a background also …
Browse files Browse the repository at this point in the history
…[Refers #3982]
  • Loading branch information
afabiani committed Nov 8, 2018
1 parent fcd711f commit a1bf0ac
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions geonode/geoserver/helpers.py
Expand Up @@ -2009,6 +2009,6 @@ def set_time_dimension(cat, name, workspace, time_presentation, time_presentatio

# main entry point to create a thumbnail - will use implementation
# defined in settings.THUMBNAIL_GENERATOR (see settings.py)
def create_gs_thumbnail(instance, overwrite=False):
def create_gs_thumbnail(instance, overwrite=False, check_bbox=False):
implementation = import_string(settings.THUMBNAIL_GENERATOR)
return implementation(instance, overwrite)
return implementation(instance, overwrite, check_bbox)
9 changes: 6 additions & 3 deletions geonode/geoserver/signals.py
Expand Up @@ -90,6 +90,8 @@ def geoserver_post_save(instance, sender, **kwargs):
instance_dict = model_to_dict(instance)
payload = json_serializer_producer(instance_dict)
producer.geoserver_upload_layer(payload)
logger.info("... Creating Thumbnail for Layer [%s]" % (instance.alternate))
create_gs_thumbnail(instance, overwrite=True, check_bbox=True)


def geoserver_post_save_local(instance, *args, **kwargs):
Expand Down Expand Up @@ -508,8 +510,8 @@ def command_url(command):

# some thumbnail generators will update thumbnail_url. If so, don't
# immediately re-generate the thumbnail here. use layer#save(update_fields=['thumbnail_url'])
if not ('update_fields' in kwargs and kwargs['update_fields'] is not None and
'thumbnail_url' in kwargs['update_fields']):
if 'update_fields' in kwargs and kwargs['update_fields'] is not None and \
'thumbnail_url' in kwargs['update_fields']:
logger.info("... Creating Thumbnail for Layer [%s]" % (instance.alternate))
create_gs_thumbnail(instance, overwrite=True)

Expand Down Expand Up @@ -632,4 +634,5 @@ def geoserver_pre_save_maplayer(instance, sender, **kwargs):

def geoserver_post_save_map(instance, sender, **kwargs):
instance.set_missing_info()
create_gs_thumbnail(instance, overwrite=False)
logger.info("... Creating Thumbnail for Map [%s]" % (instance.title))
create_gs_thumbnail(instance, overwrite=False, check_bbox=True)

0 comments on commit a1bf0ac

Please sign in to comment.