Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to build full URL #13

Closed
darribas opened this issue May 21, 2021 · 4 comments · Fixed by #28
Closed

Add method to build full URL #13

darribas opened this issue May 21, 2021 · 4 comments · Fixed by #28
Milestone

Comments

@darribas
Copy link
Contributor

This would be in lib and would build the full URL, including tokens, etc. for a TileProvider object.

@darribas darribas mentioned this issue May 21, 2021
10 tasks
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented May 23, 2021

This is basically this code from contextily to move over? -> https://github.com/geopandas/contextily/blob/799c70802892f0276ace74159df3ed24779cedbf/contextily/tile.py#L292-L298 (but a bit more expanded/documented)

@martinfleis
Copy link
Member

@jorisvandenbossche
Copy link
Member

Ah, but that's slightly different: that's building the full url except with x/y/z/s still to be filled in, while the one I linked accepts x/y/z and already fills those in as well.

Probably the s (subdomain) should already be filled in, since that can depend on the Provider information?

@martinfleis
Copy link
Member

Probably the s (subdomain) should already be filled in, since that can depend on the Provider information?

That sounds right. I think we should be able to return both options, fully filled and and with xyz placeholders. Contextily can use the first version while folium the second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants