Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandatory attributes #46

Closed
martinfleis opened this issue Jul 30, 2021 · 1 comment · Fixed by #51
Closed

Mandatory attributes #46

martinfleis opened this issue Jul 30, 2021 · 1 comment · Fixed by #51
Milestone
release

Comments

@martinfleis
Copy link
Member

name, url, and attribution should be mandatory attributes of TileProvider and we should raise otherwise.
@martinfleis martinfleis added this to the release milestone Jul 30, 2021
@darribas
Copy link
Contributor

Fix over at #51

@martinfleis martinfleis mentioned this issue Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release
Development

Successfully merging a pull request may close this issue.

ENH: always require name, url and attribution darribas/xyzservices
2 participants
@darribas @martinfleis