Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra HTTP request on filters change #104

Open
blackst0ne opened this issue Apr 10, 2018 · 0 comments
Open

Fix extra HTTP request on filters change #104

blackst0ne opened this issue Apr 10, 2018 · 0 comments

Comments

@blackst0ne
Copy link
Contributor

If a user changes anything in the filters (/events or /analytics page), two HTTP requests will be fired instead of just one.

This is because there is a watcher for $route changes which gets fired both on filters change and on URL change (for example, when walking through links to the same page but with different query params).

Either the watcher or the logic should be changed to get rid of the extra HTTP request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant