Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display filename in hash view #29

Closed
melix99 opened this issue Dec 6, 2021 · 8 comments
Closed

Display filename in hash view #29

melix99 opened this issue Dec 6, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@melix99
Copy link

melix99 commented Dec 6, 2021

Is your feature request related to a problem? Please describe.
My brain.

Describe the solution you'd like
Display the filename (or the path?) of the hashed file, so that people don't forget which file was chosen (useful especially when having to hash multiple files).

@melix99 melix99 added the enhancement New feature or request label Dec 6, 2021
@GeopJr
Copy link
Owner

GeopJr commented Dec 6, 2021

Agreed, however I am not sure how to display it. Using the title is useless as on desktop mode the ViewSwitcher covers it.

(Quick mockups)
Infobar maybe?

hashbrown with infobar showing the filepath of the current file

Or perhaps a row in the hash list?

hashbrown on the hash list view with an additional row at the top of the list with the title "filepath" and a text entry with the path of the file

Also should it be full path or just the file name?

@melix99
Copy link
Author

melix99 commented Dec 6, 2021

I'd suggest using an AdwStatusPage with the filename (or path, I'm still unsure what's better) as the title and the listbox as its child.

@GeopJr
Copy link
Owner

GeopJr commented Dec 6, 2021

It does look better, I'll add it after the rebrand is done, thanks!

hashbrown on the hash list view with a status page of "README.md" as title and the hash list box as a child

@GeopJr
Copy link
Owner

GeopJr commented Dec 9, 2021

More testing:

Normal case + title

Hashbrown hashlist with a typical file name displayed as status page title on desktop

Hashbrown hashlist with a typical file name displayed as status page title on mobile

Normal case + description

Hashbrown hashlist with a typical file name displayed as status page description on desktop

Hashbrown hashlist with a typical file name displayed as status page description on mobile

Extreme case + title

Hashbrown hashlist with a typical file name displayed as status page title on desktop

Hashbrown hashlist with a typical file name displayed as status page title on mobile

Extreme case + description

Hashbrown hashlist with a typical file name displayed as status page description on desktop

Hashbrown hashlist with a typical file name displayed as status page description on mobile

Extreme cases + titles are a bit too much, perhaps after a certain amount of characters I should add ellipsis or use description instead of text.

cc: @bertob

@melix99
Copy link
Author

melix99 commented Dec 9, 2021

Also notice that libadwaita now uses .title-1 for the title, which is a bit smaller and bolder, so it may already look better with that.

@bertob
Copy link
Contributor

bertob commented Dec 9, 2021

I agree that using a status page title makes the most sense here. Perhaps the path could even be displayed below the name as the status page description?

@GeopJr
Copy link
Owner

GeopJr commented Dec 9, 2021

(Note: .title-1 manually applied (on host) for the screenshots due to this bug)

hashbrown mobile view on hash list with status page with filename as its title and filepath as its description
hashbrown desktop view on hash list with status page with filename as its title and filepath as its description

@bertob
Copy link
Contributor

bertob commented Dec 9, 2021

Looking good!

@GeopJr GeopJr closed this as completed in cbe5528 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants