Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License clarification #49

Closed
FedericoCeratto opened this issue Jan 8, 2023 · 6 comments
Closed

License clarification #49

FedericoCeratto opened this issue Jan 8, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@FedericoCeratto
Copy link
Contributor

Hello and thanks for developing Tooth.
According to license_type in src/Application.vala and the badge in the README.md file Tooth is strictly under GPL v3.
According to data/dev.geopjr.tooth.appdata.xml.in it is under GPL-3.0+ meaning that users can pick any future version of the license at they choice.

I understand that those files might come from @bleakgrey 's repo but this little conflict should be addressed anyways if possible.

(As a side note, it is considered a good practice to add a small comment at the top of each source code file to indicate authorship and license)

Thank you!
Related to #27

@FedericoCeratto FedericoCeratto added the bug Something isn't working label Jan 8, 2023
@GeopJr
Copy link
Owner

GeopJr commented Jan 8, 2023

I probably don't have a say on this but here's the blames:

Initial commit is "or later": bleakgrey/tootle@30f8348#diff-248a3ad2376574c96e7b8fc79764c5a217d4d41c8bf8679bcca1c3b7b87f8ff2R7

Granite drop is "only": bleakgrey/tootle@748808d#diff-94f3624867a327aa824c771318c113fe3a29c5149637a70aac408b786bf2ee35R15

(I'll consider license headers on each file!)

@FedericoCeratto
Copy link
Contributor Author

Also this is the addition of the "only" in src/Application.vala https://github.com/bleakgrey/tootle/pull/310/files#diff-f4e5d48d751c670a8575715da1cb0a0976532427a8b6143c7fdede415a33ba6cR180

In my understanding regardless if @bleakgrey meant to use GPLv3 or GPLv3+ you are given the right to select GPLv3 [if that's what you want]

@GeopJr GeopJr closed this as completed in 0fd2e51 Jan 10, 2023
@GeopJr
Copy link
Owner

GeopJr commented Jan 10, 2023

I went with GPL-3.0!

@Newbytee
Copy link

GPL-3.0 and GPL-3.0+ are deprecated identifiers according to SPDX: https://spdx.org/licenses/

GPL-3.0-only and GPL-3.0-or-later are preferred.

@GeopJr
Copy link
Owner

GeopJr commented Jan 11, 2023

Done! (Changed to GPL-3.0-only)

@Newbytee
Copy link

@FedericoCeratto is there something wrong with my suggestion? Why did you downvote my comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants