Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxies: accept as string #290

Closed
KostyaEsmukov opened this issue May 7, 2018 · 0 comments · Fixed by #300
Closed

Proxies: accept as string #290

KostyaEsmukov opened this issue May 7, 2018 · 0 comments · Fixed by #300
Milestone

Comments

@KostyaEsmukov
Copy link
Member

KostyaEsmukov commented May 7, 2018

I think that accepting a single string for the proxies param would be great. The urllib2-style dict objects with schemes might be confusing to the users of geocoders.

# Current usage:
geolocator = Nominatim(scheme='https', proxies={'https': 'http://192.0.2.1:8080'})
# Proposed usage:
geolocator = Nominatim(proxies='http://192.0.2.1:8080')

#288 should be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant