Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement file paths #11

Closed
jorgejesus opened this issue Mar 7, 2018 · 1 comment
Closed

implement file paths #11

jorgejesus opened this issue Mar 7, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jorgejesus
Copy link
Member

Base provider class uses self.url to indicate where the provider is locate, this is problematic when we have for example spatialite that is a file.

Current we used file:// with asbolute paths. Need to create a specific file attriubte in the base class and support relative paths
e.g
self.file = "./data/"

@jorgejesus jorgejesus self-assigned this Mar 7, 2018
@jorgejesus jorgejesus added the enhancement New feature or request label Mar 7, 2018
@tomkralidis
Copy link
Member

I've changed the config so that we use what's intuitive to the provider. self.url is now self.data of the dataset object (along with self.id_field and self.provider. So for GeoJSON/CSV, self.data is a filepath, whereas for Elasticsearch, self.data is the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants