Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This package is really useful, shame it's no longer maintained - could I volunteer? :) #28

Open
leob opened this issue Sep 20, 2023 · 9 comments

Comments

@leob
Copy link
Collaborator

leob commented Sep 20, 2023

Hi @georgeboot,

You say "this package is no longer maintained", and I think that's a shame, it works really well for us.

I'd consider "volunteering" to take over maintenance for this package, what do you think?

Have a nice day,
Leo

P.S. you recommend "Soketi", all great and well, I looked at it, however we're running on AWS Lambda and we've based our whole architecture on it - something like Soketi doesn't play with that, it would make our AWS Lambda based architecture somewhat pointless ... laravel-echo-api-gateway really fits like a glove for us :)

@georgeboot
Copy link
Owner

Sure why not! Sounds awesome!

I'll give you triage permissions. Please just ask pr reviews from me when it's ready so I can merge and tag. If that works good, full access in the future.

@leob
Copy link
Collaborator Author

leob commented Sep 20, 2023

Okay cool, let's do it!

@michaelaguiar
Copy link

@leob I am also maintaining a fork of this at: https://github.com/aliasproject/laravel-echo-api-gateway and plan to continue to improve it if you want to join!

Let me know if it's better to work directly on this repo without @georgeboot , or on a fork. I use this on many projects and it works pretty great for me, and super easy to deploy new Websockets servers via API Gateway.

@leob
Copy link
Collaborator Author

leob commented Dec 19, 2023

@leob I am also maintaining a fork of this at: aliasproject/laravel-echo-api-gateway and plan to continue to improve it if you want to join!

Let me know if it's better to work directly on this repo without @georgeboot , or on a fork. I use this on many projects and it works pretty great for me, and super easy to deploy new Websockets servers via API Gateway.

@michaelaguiar Thanks, great to hear!

Yes I like it too - easy to install and use, works like a charm, I'm using it on a project of mine ...

Okay, let me look at your fork, and if that works for me then I'm inclined to add a note here in this repo, directing people to the fork, and make that the new 'official' one ... I'll get back to you.

@georgeboot
Copy link
Owner

Not sure how many active instals there are, but it would probably be easier for people if you can bring your changes into this repo, so people get the benefits without having to switch packages. But do what you think is best.

@leob
Copy link
Collaborator Author

leob commented Dec 19, 2023

Not sure how many active instals there are, but it would probably be easier for people if you can bring your changes into this repo, so people get the benefits without having to switch packages. But do what you think is best.

@georgeboot Yes you may be right, it might be less confusing ... let me take a look at what's in @michaelaguiar's fork and we'll figure it out.

@michaelaguiar
Copy link

Either way works for me! FYI @leob - my fork has very minimal changes from the current version here. I did fix an issue I had with deploying to Laravel Vapor and the token issue that @georgeboot mentioned in both the aws sdk repo and Laravel. I'm happy to team up on making improvements either here or in my fork.

@leob
Copy link
Collaborator Author

leob commented Dec 19, 2023

Either way works for me! FYI @leob - my fork has very minimal changes from the current version here. I did fix an issue I had with deploying to Laravel Vapor and the token issue that @georgeboot mentioned in both the aws sdk repo and Laravel. I'm happy to team up on making improvements either here or in my fork.

@michaelaguiar I'll take a look at the changes in your repo - and then maybe we can create a pull request to integrate your changes into the main repo (this one), and add you as a committer, and we can all work on it here ... that might be the nicest and least confusing way to do it :)

@michaelaguiar
Copy link

Works for me. I can create a PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants