Cascading T-Shirt Sizes (DX) #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi George! My name is justgu.us and I'm an indie dev that loves to create systematical naming conventions that spark the narrative of code in a more semantical way. I implemented my model for cascading t-shirt sizes on your spaceSteps and spacePairs naming convention, that used to be -2xl etc. It might look fresh at first, but you will soon spot the cascading pattern of the sizing I use; XX, XS, SS, SM, MM, ML, LL, LD, DD, ZZ It's a way to make fluid scales have a better relationship to each other as tokens. I believe that will improve the user experience of end-users to create their own customPairs like I did, plus it makes for a programmatical pattern to step up or down the scales & sizes if you wish to take it further. As a bonus, it cleans up the tokens quite nicely and makes them all stick to using the same amount of characters per token. I added one step that was missing in the current spacePairs; the use of 3XL (-ZZ) as a pair at the end. Thanks for reviewing and take care!
✅ Deploy Preview for fluid-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Cool to see it working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi George!
My name is justgu.us and I'm an indie dev that loves to create systematical naming conventions that spark the narrative of code in a more semantical way.
I implemented my model for cascading t-shirt sizes on your spaceSteps and spacePairs naming convention, that used to be -2xl etc. It might look fresh at first, but you will soon spot the cascading pattern of the sizing I use; XX, XS, SS, SM, MM, ML, LL, LD, DD, ZZ
It's a way to make fluid scales have a better relationship to each other as tokens using the t-shirt sizes that we know, plus Display. And as a refactoring-bonus; they are just "imaginary" numbers anyway, steps on a scale. So exchange the D with anything you see fit after Large.
I believe the semantics will improve the user experience of end-users to create their own customPairs like I did, plus it makes for a programmatical pattern to step up or down the scales & sizes if you wish to take it further in procedural coding.
As a reading experience bonus for both humans and computers, it cleans up the tokens quite nicely and makes them all stick to using the same amount of characters per token. Optimized for reduction.
I added one step that was missing in the current spacePairs btw; the use of 3XL (-ZZ) as a pair at the end. Should you choose not to use these tokens, then at least the notice of a missing pair was of value ;)
Thanks for reviewing and take care!