Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success/error toast on adding recipes #5

Closed
georgegebbett opened this issue May 7, 2022 · 3 comments · Fixed by #7
Closed

Success/error toast on adding recipes #5

georgegebbett opened this issue May 7, 2022 · 3 comments · Fixed by #7
Assignees
Labels
enhancement New feature or request

Comments

@georgegebbett
Copy link
Owner

At the moment when you add a recipe, the dialog just closes and the recipe appears, or the dialog stays open and the recipe does not if it fails.

This is confusing and some kind of better error handling in the UI is required.

@mshuflin
Copy link

mshuflin commented May 9, 2022

Is the error logged somewhere that we could use as a workaround at the moment?

@georgegebbett
Copy link
Owner Author

It should probably be visible in the network tab of the Chrome DevTools - a POST to /api/recipes is made on adding a recipe so this is the call to look for
image

@georgegebbett
Copy link
Owner Author

georgegebbett commented May 9, 2022

All added - I'll do a release which will rebuild the Docker images and as long as you're using the latest version of the docker-compose file which uses the pre-built images you should see the toasts after re-pulling the images.

@georgegebbett georgegebbett added the enhancement New feature or request label May 9, 2022
@georgegebbett georgegebbett self-assigned this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants